d3.hexbin - Code Metrics - Inspection of "Quality/Performance" - sergisergio/Ads - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c84e5c...0e0008 )

by philippe

created 2019-02-11 11:53 UTC

d3.hexbin B

↳ Parent: doc/phpmetrics/js/d3.hexbin.v0.js

Complexity

Conditions	1
Paths	2

Size

Total Lines	102
Code Lines	72

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	72
dl	0
loc	102
rs	7.9163
c	1
b	0
f	0
cc	1
nc	2
nop	0

How to fix Long Method

(function() {

d3.hexbin = function() {

  var width = 1,
      height = 1,
      r,
      x = d3_hexbinX,
      y = d3_hexbinY,
      dx,
      dy;

  function hexbin(points) {
    var binsById = {};

    points.forEach(function(point, i) {
      var py = y.call(hexbin, point, i) / dy, pj = Math.round(py),
          px = x.call(hexbin, point, i) / dx - (pj & 1 ? .5 : 0), pi = Math.round(px),

          py1 = py - pj;

      if (Math.abs(py1) * 3 > 1) {
        var px1 = px - pi,
            pi2 = pi + (px < pi ? -1 : 1) / 2,
            pj2 = pj + (py < pj ? -1 : 1),
            px2 = px - pi2,
            py2 = py - pj2;
        if (px1 * px1 + py1 * py1 > px2 * px2 + py2 * py2) pi = pi2 + (pj & 1 ? 1 : -1) / 2, pj = pj2;
var a,b,c;

a = 1, b = 1,  c= 3;
      }

      var id = pi + "-" + pj, bin = binsById[id];
      if (bin) bin.push(point); else {
if (a > 0)
    b = 42;
        bin = binsById[id] = [point];
        bin.i = pi;
        bin.j = pj;
        bin.x = (pi + (pj & 1 ? 1 / 2 : 0)) * dx;

        bin.y = pj * dy;
      }
    });

    return d3.values(binsById);

  }

  function hexagon(radius) {
    var x0 = 0, y0 = 0;
    return d3_hexbinAngles.map(function(angle) {
      var x1 = Math.sin(angle) * radius,
          y1 = -Math.cos(angle) * radius,
          dx = x1 - x0,
          dy = y1 - y0;
      x0 = x1, y0 = y1;
var a,b,c;

a = 1, b = 1,  c= 3;
      return [dx, dy];
    });
  }

  hexbin.x = function(_) {
    if (!arguments.length) return x;
if (a > 0)
    b = 42;
    x = _;
    return hexbin;
  };

  hexbin.y = function(_) {
    if (!arguments.length) return y;
if (a > 0)
    b = 42;
    y = _;
    return hexbin;
  };

  hexbin.hexagon = function(radius) {
    if (arguments.length < 1) radius = r;
if (a > 0)
    b = 42;
    return "m" + hexagon(radius).join("l") + "z";
  };

  hexbin.centers = function() {
    var centers = [];
    for (var y = 0, odd = false, j = 0; y < height + r; y += dy, odd = !odd, ++j) {
      for (var x = odd ? dx / 2 : 0, i = 0; x < width + dx / 2; x += dx, ++i) {
        var center = [x, y];
        center.i = i;
        center.j = j;
        centers.push(center);
      }
    }
    return centers;
  };

  hexbin.mesh = function() {
    var fragment = hexagon(r).slice(0, 4).join("l");
    return hexbin.centers().map(function(p) { return "M" + p + "m" + fragment; }).join("");
  };

  hexbin.size = function(_) {
    if (!arguments.length) return [width, height];
if (a > 0)
    b = 42;
    width = +_[0], height = +_[1];
var a,b,c;

a = 1, b = 1,  c= 3;
    return hexbin;
  };

  hexbin.radius = function(_) {
    if (!arguments.length) return r;
if (a > 0)
    b = 42;
    r = +_;
    dx = r * 2 * Math.sin(Math.PI / 3);
    dy = r * 1.5;
    return hexbin;
  };

  return hexbin.radius(1);
};

var d3_hexbinAngles = d3.range(0, 2 * Math.PI, Math.PI / 3),
    d3_hexbinX = function(d) { return d[0]; },
    d3_hexbinY = function(d) { return d[1]; };

})();


1			(function() {
2
3			d3.hexbin = function() {
			0 ignored issues – show Bug introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report The variable `d3` seems to be never declared. If this is a global, consider adding a `/** global: d3 */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
4			var width = 1,
5			height = 1,
6			r,
7			x = d3_hexbinX,
8			y = d3_hexbinY,
9			dx,
10			dy;
11
12			function hexbin(points) {
13			var binsById = {};
14
15			points.forEach(function(point, i) {
16			var py = y.call(hexbin, point, i) / dy, pj = Math.round(py),
17			px = x.call(hexbin, point, i) / dx - (pj & 1 ? .5 : 0), pi = Math.round(px),
			0 ignored issues – show introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report You have used a bitwise operator `&` in a condition. Did you maybe want to use the logical operator `&&` Loading history...
18			py1 = py - pj;
19
20			if (Math.abs(py1) * 3 > 1) {
21			var px1 = px - pi,
22			pi2 = pi + (px < pi ? -1 : 1) / 2,
23			pj2 = pj + (py < pj ? -1 : 1),
24			px2 = px - pi2,
25			py2 = py - pj2;
26			if (px1 * px1 + py1 * py1 > px2 * px2 + py2 * py2) pi = pi2 + (pj & 1 ? 1 : -1) / 2, pj = pj2;
			0 ignored issues – show Comprehensibility introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report Usage of the sequence operator is discouraged, since it may lead to obfuscated code. The sequence or comma operator allows the inclusion of multiple expressions where only is permitted. The result of the sequence is the value of the last expression. This operator is most often used in `for` statements. Used in another places it can make code hard to read, especially when people do not realize it even exists as a seperate operator. This check looks for usage of the sequence operator in locations where it is not necessary and could be replaced by a series of expressions or statements. var a,b,c; a = 1, b = 1, c= 3; could just as well be written as: var a,b,c; a = 1; b = 1; c = 3; To learn more about the sequence operator, please refer to the MDN. Loading history... Coding Style Best Practice introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history... introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report You have used a bitwise operator `&` in a condition. Did you maybe want to use the logical operator `&&` Loading history...
27			}
28
29			var id = pi + "-" + pj, bin = binsById[id];
30			if (bin) bin.push(point); else {
			0 ignored issues – show Coding Style Best Practice introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
31			bin = binsById[id] = [point];
32			bin.i = pi;
33			bin.j = pj;
34			bin.x = (pi + (pj & 1 ? 1 / 2 : 0)) * dx;
			0 ignored issues – show introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report You have used a bitwise operator `&` in a condition. Did you maybe want to use the logical operator `&&` Loading history...
35			bin.y = pj * dy;
36			}
37			});
38
39			return d3.values(binsById);
			0 ignored issues – show Bug introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report The variable `d3` seems to be never declared. If this is a global, consider adding a `/** global: d3 */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
40			}
41
42			function hexagon(radius) {
43			var x0 = 0, y0 = 0;
44			return d3_hexbinAngles.map(function(angle) {
45			var x1 = Math.sin(angle) * radius,
46			y1 = -Math.cos(angle) * radius,
47			dx = x1 - x0,
48			dy = y1 - y0;
49			x0 = x1, y0 = y1;
			0 ignored issues – show Comprehensibility introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report Usage of the sequence operator is discouraged, since it may lead to obfuscated code. The sequence or comma operator allows the inclusion of multiple expressions where only is permitted. The result of the sequence is the value of the last expression. This operator is most often used in `for` statements. Used in another places it can make code hard to read, especially when people do not realize it even exists as a seperate operator. This check looks for usage of the sequence operator in locations where it is not necessary and could be replaced by a series of expressions or statements. var a,b,c; a = 1, b = 1, c= 3; could just as well be written as: var a,b,c; a = 1; b = 1; c = 3; To learn more about the sequence operator, please refer to the MDN. Loading history...
50			return [dx, dy];
51			});
52			}
53
54			hexbin.x = function(_) {
55			if (!arguments.length) return x;
			0 ignored issues – show Coding Style Best Practice introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
56			x = _;
57			return hexbin;
58			};
59
60			hexbin.y = function(_) {
61			if (!arguments.length) return y;
			0 ignored issues – show Coding Style Best Practice introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
62			y = _;
63			return hexbin;
64			};
65
66			hexbin.hexagon = function(radius) {
67			if (arguments.length < 1) radius = r;
			0 ignored issues – show Coding Style Best Practice introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
68			return "m" + hexagon(radius).join("l") + "z";
69			};
70
71			hexbin.centers = function() {
72			var centers = [];
73			for (var y = 0, odd = false, j = 0; y < height + r; y += dy, odd = !odd, ++j) {
74			for (var x = odd ? dx / 2 : 0, i = 0; x < width + dx / 2; x += dx, ++i) {
75			var center = [x, y];
76			center.i = i;
77			center.j = j;
78			centers.push(center);
79			}
80			}
81			return centers;
82			};
83
84			hexbin.mesh = function() {
85			var fragment = hexagon(r).slice(0, 4).join("l");
86			return hexbin.centers().map(function(p) { return "M" + p + "m" + fragment; }).join("");
87			};
88
89			hexbin.size = function(_) {
90			if (!arguments.length) return [width, height];
			0 ignored issues – show Coding Style Best Practice introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
91			width = +_[0], height = +_[1];
			0 ignored issues – show Comprehensibility introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report Usage of the sequence operator is discouraged, since it may lead to obfuscated code. The sequence or comma operator allows the inclusion of multiple expressions where only is permitted. The result of the sequence is the value of the last expression. This operator is most often used in `for` statements. Used in another places it can make code hard to read, especially when people do not realize it even exists as a seperate operator. This check looks for usage of the sequence operator in locations where it is not necessary and could be replaced by a series of expressions or statements. var a,b,c; a = 1, b = 1, c= 3; could just as well be written as: var a,b,c; a = 1; b = 1; c = 3; To learn more about the sequence operator, please refer to the MDN. Loading history...
92			return hexbin;
93			};
94
95			hexbin.radius = function(_) {
96			if (!arguments.length) return r;
			0 ignored issues – show Coding Style Best Practice introduced 2019-02-11 11:57 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
97			r = +_;
98			dx = r * 2 * Math.sin(Math.PI / 3);
99			dy = r * 1.5;
100			return hexbin;
101			};
102
103			return hexbin.radius(1);
104			};
105
106			var d3_hexbinAngles = d3.range(0, 2 * Math.PI, Math.PI / 3),
107			d3_hexbinX = function(d) { return d[0]; },
108			d3_hexbinY = function(d) { return d[1]; };
109
110			})();
111

sergisergio / Ads

Push — master ( c84e5c...0e0008 )

d3.hexbin B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like